test: add apiv2 coverage for the manifest-create images query param#28984
Open
stefan8 wants to merge 1 commit into
Open
test: add apiv2 coverage for the manifest-create images query param#28984stefan8 wants to merge 1 commit into
stefan8 wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
kind/api-change
stefan8
force-pushed
the
test/apiv2-manifest-create-images-query
branch
2 times, most recently
from
93c4bf5 to
387ee2b
Compare
Contributor
Author
|
/packit retest-failed |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Honny1
approved these changes
Jun 22, 2026
Honny1
left a comment
Honny1
left a comment
Contributor
There was a problem hiding this comment.
LGTM
PTAL @podman-container-tools/podman-reviewers @podman-container-tools/podman-maintainers
| EOF | ||
| ) | ||
|
|
||
| # Create manifest lists and populate them at creation time via the `images` |
Contributor
There was a problem hiding this comment.
Non-blocking: I would add a case like images=containers-storage:$id_abc_image&images=containers-storage:$id_xyz_image with an assertion of '.manifests | length'=2.
Contributor
|
LGTM, same with @Honny1 's comment, if you could the case and push the update that would be great, but non blocking |
The libpod manifest-create endpoint takes an "images" query parameter that
fills the new list at creation time, but 15-manifest.at never tested it.
Add cases that create a list with images= on both the v4
(/manifests/{name}, 201) and v3 (/manifests/create, 200) endpoints and
check the image ends up in the list.
Also drop the stale "required: true" from the images query parameter in the
swagger docs - the handler treats it as optional, and the existing create
tests (which omit it) already show that.
Fixes: podman-container-tools#22258
Signed-off-by: Grzegorz Szczepanczyk <g.szczepanczyk@getprintbox.com>
stefan8
force-pushed
the
test/apiv2-manifest-create-images-query
branch
from
387ee2b to
11daf50
Compare
Honny1
approved these changes
Jul 9, 2026
Honny1
left a comment
Honny1
left a comment
Contributor
There was a problem hiding this comment.
LGTM
This failure seems to be unrelated. I rerun tests.
+ /home/ubuntu/golangci-lint-2.12.2-linux-amd64/golangci-lint run --build-tags=apparmor,seccomp,selinux
Error: utils/utils.go:16:2: could not import go.podman.io/storage/pkg/archive (/home/ubuntu/go/pkg/mod/go.podman.io/storage@v1.63.1-0.20260611132908-ea2c6da53f91/pkg/archive/archive.go:21:7: could not import github.com/klauspost/pgzip (/home/ubuntu/go/pkg/mod/github.com/klauspost/pgzip@v1.2.6/gunzip.go:26:2: could not import github.com/klauspost/compress/flate (../../../go/pkg/mod/github.com/klauspost/pgzip@v1.2.6/gunzip.go:26:2: github.com/klauspost/compress@v1.18.6: reading https://proxy.golang.org/github.com/klauspost/compress/@v/v1.18.6.zip: 403 Forbidden))) (typecheck)
"go.podman.io/storage/pkg/archive"
^
1 issues:
* typecheck: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libpod manifest-create
imagesquery parameter was never covered by the apiv2 tests. This adds cases for it on the v3 and v4 endpoints, and drops the stalerequired: truefrom that parameter in the swagger docs (the handler treats it as optional).Checklist
git commit -s).Fixes: #22258in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?